Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_behalf_of to CardField #1750

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Add on_behalf_of to CardField #1750

merged 2 commits into from
Oct 11, 2024

Conversation

davidme-stripe
Copy link
Collaborator

@davidme-stripe davidme-stripe commented Oct 11, 2024

Summary

Add support for on_behalf_of to CardField

Motivation

Testing

  • I tested this manually
  • I added automated tests

Documentation

Added doc comment and changelog entry.
Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@davidme-stripe davidme-stripe marked this pull request as ready for review October 11, 2024 23:47
@davidme-stripe davidme-stripe merged commit 64f1580 into master Oct 11, 2024
4 of 6 checks passed
@davidme-stripe davidme-stripe deleted the davidme/obo-cardfield branch October 11, 2024 23:51
@Jleban
Copy link

Jleban commented Nov 20, 2024

Hello,
Using the new NEW_ARCH (Fabric), the app crashes with the error: Swift runtime failure: force unwrapped a nil value + 0 [inlined] closure #1 in CardFieldManager.blur(_:) + 484 when the component containing CardField is unmounted while the CardField is focused. You can check it here: #1732 (comment)

Do you see a fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants